Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve background color #425

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

joshmedeski
Copy link
Contributor

Closes #424

Adjusting the get_background_color_of_highlight_group function to support cleared highlight groups.

  • Falling back to highlight_group_normal.foreground is both confusing and makes it impossible to overwrite the default background value to a null value. So I've removed it.
  • Removed the fallback else if background color isn't defined. In my case, I don't want there to be a background color so I'm clearing the OctoEditable highlight but the previous logic would still add a color back.

Does this pull request fix one issue?

Resolves #424

Special notes for reviews

Please let me know if the black background was intentional. And if so, what I would need to do to allow the get_background_color_of_highlight_group to return a cleared value so I can get a transparent UI.

@pwntester
Copy link
Owner

Thanks! it looks good to me. I guess I was using black as the fall safe option, but it makes sense to allow the color to be cleared

@pwntester pwntester merged commit 22a231f into pwntester:master Oct 5, 2023
1 of 2 checks passed
@joshmedeski joshmedeski deleted the improve-background branch October 5, 2023 21:43
@joshmedeski
Copy link
Contributor Author

No, thank YOU! I love using this plugin, such a time saver.

And thanks for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants