Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A proposal for cache validation #16

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

Vinye
Copy link
Contributor

@Vinye Vinye commented Dec 5, 2020

I keep repeating the mistake of using old invalid cache without noticing it, so here is a simple proposal for validation method. Related to issue #10

@matiaslindgren
Copy link
Member

Thanks! This looks good and will be efficient even for large dataframes. I was initially thinking about automatically deleting invalid caches, but making this an error is actually better since the user might not want to always delete old caches.

@matiaslindgren matiaslindgren merged commit d9aca88 into py-lidbox:master Dec 5, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants