Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Changed conf.py to make myst parse all links as simple hyperlinks #1506

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

mbromet
Copy link
Contributor

@mbromet mbromet commented Dec 17, 2022

Added myst_all_links_external = True to conf.py's global configuration as described here

Closes #1492

@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Base: 92.58% // Head: 92.03% // Decreases project coverage by -0.54% ⚠️

Coverage data is based on head (122f6ef) compared to base (74b8a63).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
- Coverage   92.58%   92.03%   -0.55%     
==========================================
  Files          32       32              
  Lines        5971     5976       +5     
  Branches     1163     1163              
==========================================
- Hits         5528     5500      -28     
- Misses        284      312      +28     
- Partials      159      164       +5     
Impacted Files Coverage Δ
PyPDF2/_protocols.py 80.00% <100.00%> (-1.25%) ⬇️
PyPDF2/_utils.py 97.46% <100.00%> (-2.02%) ⬇️
PyPDF2/_writer.py 83.94% <100.00%> (-1.17%) ⬇️
PyPDF2/generic/_annotations.py 96.66% <0.00%> (-3.34%) ⬇️
PyPDF2/_page.py 89.56% <0.00%> (-2.40%) ⬇️
PyPDF2/xmp.py 92.10% <0.00%> (ø)
PyPDF2/types.py 100.00% <0.00%> (ø)
PyPDF2/errors.py 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma merged commit 9b23a39 into py-pdf:main Dec 17, 2022
@MartinThoma
Copy link
Member

Very nice! Thank you 🤗

@MartinThoma
Copy link
Member

If you want, I can add you to https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

@mbromet
Copy link
Contributor Author

mbromet commented Dec 17, 2022

If you want, I can add you to https://pypdf2.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

That would be really cool, thank you!

MartinThoma added a commit that referenced this pull request Dec 22, 2022
BREAKING CHANGES:
-  Deprecate features with PyPDF2==3.0.0 (#1489)
-  Refactor Fit / Zoom parameters (#1437)

New Features (ENH):
-  Add Cloning  (#1371)
-  Allow int for indirect_reference in PdfWriter.get_object (#1490)

Documentation (DOC):
-  How to read PDFs from S3 (#1509)
-  Make MyST parse all links as simple hyperlinks (#1506)
-  Changed 'latest' for 'stable' generated docs (#1495)
-  Adjust deprecation procedure (#1487)

Maintenance (MAINT):
-  Use typing.IO for file streams (#1498)

[Full Changelog](2.12.1...3.0.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken cross-reference links in docs
2 participants