Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add page_number property #1856

Merged
merged 3 commits into from
Jun 19, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pypdf/_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -1519,6 +1519,23 @@ def compressContentStreams(self) -> None: # deprecated
)
self.compress_content_streams()

@property
def page_number(self) -> int:
"""
Read-only property which return the page number with the pdf file.

Returns:
int : page number ; -1 if the page is not attached to a pdf
"""
if self.indirect_reference is None:
return -1
MartinThoma marked this conversation as resolved.
Show resolved Hide resolved
else:
try:
lst = self.indirect_reference.pdf.pages
return lst.index(self)
except ValueError:
return -1
MartinThoma marked this conversation as resolved.
Show resolved Hide resolved

def _debug_for_extract(self) -> str: # pragma: no cover
out = ""
for ope, op in ContentStream(
Expand Down
14 changes: 13 additions & 1 deletion tests/test_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,13 +261,18 @@ def test_page_transformations():
)
def test_compress_content_streams(pdf_path, password):
reader = PdfReader(pdf_path)

writer = PdfWriter()
if password:
reader.decrypt(password)
for i, page in enumerate(reader.pages):
assert i == page.page_number

assert isinstance(reader.pages[0].get_contents(), ContentStream)
writer.clone_document_from_reader(reader)
assert isinstance(writer.pages[0].get_contents(), ContentStream)
for page in writer.pages:
for i, page in enumerate(writer.pages):
assert i == page.page_number
page.compress_content_streams()

# test from reader should fail as adding_object out of
Expand Down Expand Up @@ -1119,6 +1124,13 @@ def test_merge_transformed_page_into_blank():
True,
True,
)
blank = PageObject.create_blank_page(width=100, height=100)
assert blank.page_number == -1
inserted_blank = w.add_page(blank)
assert blank.page_number == -1 # the inserted page is a clone
assert inserted_blank.page_number == len(w.pages) - 1
del w._pages.get_object()["/Kids"][-1]
assert inserted_blank.page_number == -1


def test_pages_printing():
Expand Down