MAINT: Prepare for adding AES support via #1816 #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full credit goes to exiledkingcc This PR was only made to make it easier to merge the other changes / to avoid merge conflicts. Co-authored-by: exiledkingcc <exiledkingcc@gmail.com>
MartinThoma
added
the
is-maintenance
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
- Coverage 93.85% 92.85% -1.00%
==========================================
Files 34 34
Lines 6964 7056 +92
Branches 1375 1389 +14
==========================================
+ Hits 6536 6552 +16
- Misses 282 358 +76
Partials 146 146
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CryptFilter.encrypt_objectimplementedAlgV5.generate_valuesnow crops the user_password / owner_password to 127 bytesEncryptAlgorithmEnum was added. It contains the parameter V (version), R (revision), and lengthEncryption.encrypt_objectwas addedEncryption.write_entrywas addedEncryption.makewas addedThis PR was only made to make it easier to merge the other changes / to avoid merge conflicts of other changes with #1816 . Full credit goes to exiledkingcc.
The PR is marked as "MAINT" as it doesn't add a new feature that an end-user could use.