Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix indexed/CMYK images #2039

Merged
merged 2 commits into from
Jul 30, 2023
Merged

BUG: Fix indexed/CMYK images #2039

merged 2 commits into from
Jul 30, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #2030

there is a TODO in pypdf/filters.py:L889 as currently pillow does not accept( cf CMYK palette in python-pillow/Pillow#7309)

pypdf/filters.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 90.00% and project coverage change: +0.03% 🎉

Comparison is base (29a29fe) 94.16% compared to head (bc73a42) 94.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2039      +/-   ##
==========================================
+ Coverage   94.16%   94.20%   +0.03%     
==========================================
  Files          41       41              
  Lines        7313     7328      +15     
  Branches     1434     1440       +6     
==========================================
+ Hits         6886     6903      +17     
+ Misses        266      265       -1     
+ Partials      161      160       -1     
Files Changed Coverage Δ
pypdf/filters.py 94.30% <90.00%> (+0.57%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinThoma MartinThoma merged commit f617f69 into py-pdf:main Jul 30, 2023
MartinThoma added a commit that referenced this pull request Aug 6, 2023
### New Features (ENH)
-  Add `level` parameter to compress_content_streams (#2044)
-  Process /uniHHHH for text_extract (#2043)

### Bug Fixes (BUG)
-  Fix AnnotationBuilder.link (#2066)
-  JPX image without ColorSpace  (#2062)
-  Added check for field /Info when cloning reader document (#2055)
-  Fix indexed/CMYK images (#2039)

### Maintenance (MAINT)
-  Cryptography as primary dependency (#2053)

[Full Changelog](3.14.0...3.15.0)
@pubpub-zz pubpub-zz deleted the ind_cmyk branch September 2, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image extraction raises "ValueError: illegal image mode"
2 participants