Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STY: Modify error messages in PdfWriter #2902

Merged
merged 5 commits into from
Oct 14, 2024
Merged

STY: Modify error messages in PdfWriter #2902

merged 5 commits into from
Oct 14, 2024

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Oct 14, 2024 •
edited
Loading

Also some documentation tweaks.

@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (f5c3cf2) to head (f9d2fd8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2902   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          52       52           
  Lines        8726     8726           
  Branches     1589     1589           
=======================================
  Hits         8416     8416           
  Misses        182      182           
  Partials      128      128

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-t-1 j-t-1 changed the title DOC: Documentation tweaks in PdfWriter STY: Modify error messages Oct 14, 2024
@j-t-1 j-t-1 changed the title STY: Modify error messages STY: Modify error messages in PdfWriter Oct 14, 2024
@stefan6419846
Copy link
Collaborator

When we are already at it: Could you please start the error messages with an uppercase letter where suitable?

@j-t-1
STY: Modify error messages
7a75479 
Also some documentation tweaks in PdfWriter
@j-t-1
STY: Modify error messages
f9d2fd8 
Also some documentation tweaks in PdfWriter
@stefan6419846 stefan6419846 merged commit 482a484 into py-pdf:main Oct 14, 2024
17 checks passed
@j-t-1 j-t-1 deleted the documentation branch October 15, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-t-1 @stefan6419846