Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Don't close stream passed to PdfWriter.write() #2909

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Use tmp_path to avoid needing to unlink.

3d6b7dc
Select commit
Loading
Failed to load commit list.
Open

BUG: Don't close stream passed to PdfWriter.write() #2909

Use tmp_path to avoid needing to unlink.
3d6b7dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 21, 2024 in 0s

96.44% (+0.00%) compared to 80c3939

View this Pull Request on Codecov

96.44% (+0.00%) compared to 80c3939

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (80c3939) to head (3d6b7dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2909   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          52       52           
  Lines        8728     8730    +2     
  Branches     1589     1589           
=======================================
+ Hits         8418     8420    +2     
  Misses        182      182           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.