Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and maintain m-separation function #46

Merged
merged 5 commits into from
Feb 5, 2023

Conversation

jaron-lee
Copy link
Collaborator

@jaron-lee jaron-lee commented Feb 4, 2023

Signed-off-by: Jaron Lee jaron2005@gmail.com

Fixes #43, #44
Closes: #45

Changes proposed in this pull request:

  • Implemented support for m-separation with undirected edges
  • Fixed a bug in MixedEdgeGraph with only bidirected edges, where incorrect m-separation statements were being returned
  • General refactoring and rewriting of documentation for improved clarity

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Jaron Lee <jaron2005@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #46 (808f3a4) into main (c243bda) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   68.52%   68.90%   +0.37%     
==========================================
  Files          27       27              
  Lines        2005     2029      +24     
  Branches      484      497      +13     
==========================================
+ Hits         1374     1398      +24     
  Misses        526      526              
  Partials      105      105              
Impacted Files Coverage Δ
..._graphs/networkx/algorithms/causal/m_separation.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Jaron Lee <jaron2005@gmail.com>
Signed-off-by: Jaron Lee <jaron2005@gmail.com>
docs/whats_new/v0.1.rst Outdated Show resolved Hide resolved
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just trying to fix the sphinx error

@adam2392 adam2392 merged commit 35e860c into py-why:main Feb 5, 2023
@adam2392
Copy link
Collaborator

adam2392 commented Feb 5, 2023

Thanks @jaron-lee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for undirected edges in m-separation
3 participants