Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add the ability to check the validity of an MAG #90

Closed
wants to merge 2 commits into from

Conversation

aryan26roy
Copy link
Collaborator

Closes #89

Changes proposed in this pull request:

  • Add a function to check the validity of an MAG.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #90 (183ece1) into main (013513b) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

❗ Current head 183ece1 differs from pull request most recent head 6132669. Consider uploading reports for the commit 6132669 to get more accurate results

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   76.72%   76.68%   -0.04%     
==========================================
  Files          42       42              
  Lines        3317     3320       +3     
  Branches      952      952              
==========================================
+ Hits         2545     2546       +1     
- Misses        570      572       +2     
  Partials      202      202              
Files Changed Coverage Δ
pywhy_graphs/algorithms/generic.py 83.52% <33.33%> (-0.88%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Aryan Roy and others added 2 commits July 30, 2023 16:46
Signed-off-by: Aryan Roy <aryanroy@Aryans-MacBook-Air.local>
Signed-off-by: “Aryan <“aryanroy5678@gmail.com”>
Signed-off-by: “Aryan <“aryanroy5678@gmail.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the Validity of an MAG
1 participant