-
-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sadly onnxruntime-gpu dependency kills Mac support #1505
Comments
Thank you for your issue.You might want to check the FAQ if you haven't done so already. Feel free to close this issue if you found an answer in the FAQ. If your issue is a feature request, please read this first and update your request accordingly, if needed. If your issue is a bug report, please provide a minimum reproducible example as a link to a self-contained Google Colab notebook containing everthing needed to reproduce the bug:
Providing an MRE will increase your chance of getting an answer from the community (either maintainers or other power users). Companies relying on
|
Can you please clarify what you mean by "kills Mac support"? |
I wasn't able to install |
Unfortunately I don't own an M2 mac myself (M1, it is). |
You can just use a previous version of pyannote.audio. Find a commit before 3.0.1 and install it. |
I have mac with intel chipset and same for me. I cannot install version 3.0.1 only 3.0.0 |
This is simply because onnxruntime-gpu does not have mac support. |
I reproduced the issue in our CI pipeline, you can see the build failure on macos-latest caused by pyannote.
While this is a viable workaround, it shouldn't be the solution. Breaking compatibility with an entire operating system shouldn't be introduced with a patch bump, and the loss of interoperability between 3.0.0 and 3.0.1 should be considered a bug. The OP's suggestion of platform dependent requirements seems like a good middle path between backwards compatibility and fixing the bug which required the new dependency. |
Thanks for the feedback. Would any of you be willing to contribute to the project by opening a PR solving this issue? |
I can do, but may need help to test it on other machines. |
This patch alters the requirements to use another ONNX runtime package which provides pre-build wheels for for Apple Silicon in case of running on arm64/M1/M2 Mac. Fixes pyannote#1505
Closing as latest version no longer relies on ONNX runtime. |
Hi, thanks for the great package. Sadly the recently (3.0.1) introduced
onnxruntime-gpu
dependency kills Mac support. At least on M2 (didn't try anything else).Describe the solution you'd like
onnxruntime
?The text was updated successfully, but these errors were encountered: