update to_pygfx #31
update to_pygfx #31
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
+ Coverage 96.65% 96.76% +0.10%
==========================================
Files 151 151
Lines 1856 1857 +1
==========================================
+ Hits 1794 1797 +3
+ Misses 62 60 -2 ☔ View full report in Codecov by Sentry. |
tests/test_third_party.py
Outdated
| @@ -79,19 +79,20 @@ def test_plotly() -> None: | |||
| px.imshow(IMG, color_continuous_scale=CMAP.to_plotly()) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(bool(os.getenv("CI")), reason="segfaults") | |||
| @pytest.mark.skipif(bool(os.getenv("CI")), reason="need to fix drivers") | |||
There was a problem hiding this comment.
fpl and pygfx CI might offer some help, you need to add a step to install lavapipe in your CI workflow: https://github.com/fastplotlib/fastplotlib/blob/main/.github/workflows/ci.yml#L131-L134
If you want create test screenshots of the canvas, you can use the offscreen canvas (I think you can also take a screenshot of a Qt window or widget and save that to pngs).
There was a problem hiding this comment.
Thanks @kushalkolar. I did actually have that in a previous commit tlambert03@17b0c47... but then the xvfb tests failed for some reason. All the other third party tests work fine with that setup though, so I need to find something that works for all of them.
updates the to_pygfx method to deal with some upstream deprecations