Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEI transfer coefficient #2338

Closed
brosaplanella opened this issue Oct 4, 2022 · 3 comments · Fixed by #2425
Closed

SEI transfer coefficient #2338

brosaplanella opened this issue Oct 4, 2022 · 3 comments · Fixed by #2425
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours

Comments

@brosaplanella
Copy link
Sponsor Member

The SEI transfer coefficient for reaction limited and EC reaction limited have the transfer coefficient hardcoded to 0.5. This value is a modelling assumption (see Safari et al. 2009), so I think we should allow to define it in the parameter values so it can be changed.
@valentinsulzer
Copy link
Member

Sure. Let's handle it the same way as symmetric/asymmetric BV. Add new SEI options "reaction limited (asymmetric)" and "EC reaction limited (asymmetric)" which require the transfer coefficient to be defined.

@valentinsulzer valentinsulzer added the difficulty: easy A good issue for someone new. Can be done in a few hours label Oct 11, 2022
@brosaplanella
Copy link
Sponsor Member Author

Shall I leave the option "reaction limited" (which defaults to the symmetric) with a deprecation warning? Or just introduce a breaking change?

brosaplanella added a commit that referenced this issue Nov 3, 2022
@brosaplanella
#2338 introduce alpha_SEI
814e94d
@brosaplanella brosaplanella mentioned this issue Nov 3, 2022
Merged
8 tasks
brosaplanella added a commit that referenced this issue Nov 3, 2022
@brosaplanella
#2338 fix options
880b01a
@valentinsulzer
Copy link
Member

Definitely have a deprecation warning if it changes. I'm not sure it needs to be changed though?

brosaplanella added a commit that referenced this issue Nov 3, 2022
@brosaplanella
#2338 fix integration tests
4941a33
brosaplanella added a commit that referenced this issue Nov 3, 2022
@brosaplanella
#2338 fix failing tests
4bea6fd
brosaplanella added a commit that referenced this issue Nov 3, 2022
@brosaplanella
#2338 revert breaking changes
404031c
brosaplanella added a commit that referenced this issue Nov 3, 2022
@brosaplanella
#2338 update CHANGELOG
d0fb15d
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Asymmetric SEI reaction pybamm-team/PyBaMM
2 participants
@valentinsulzer @brosaplanella