Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sundials Banded solvers for SPM, SPMe #2643

Closed
martinjrobins opened this issue Jan 31, 2023 · 0 comments · Fixed by #2677
Closed

Use Sundials Banded solvers for SPM, SPMe #2643

martinjrobins opened this issue Jan 31, 2023 · 0 comments · Fixed by #2677
Assignees
@martinjrobins
Labels
feature

Comments

@martinjrobins
Copy link
Contributor

martinjrobins commented Jan 31, 2023 •
edited
Loading

Description

the SPM and SPMe models both give jacobian matrices that are banded, should be able to get a big speed-up swapping to sundials banded solvers for the idaklu solver (#2217)

Motivation

speed-up for solving SPM and SPMe models

Possible Implementation

No response

Additional context

No response
martinjrobins added a commit that referenced this issue Feb 1, 2023
@martinjrobins
#2643 add using banded options flag
4e1cbd3
@martinjrobins martinjrobins self-assigned this Feb 1, 2023
martinjrobins added a commit that referenced this issue Feb 8, 2023
@martinjrobins
#2643 copy sparse data to banded matrix
2764c3c
martinjrobins added a commit that referenced this issue Feb 10, 2023
@martinjrobins
#2643 banded solver works on SPM and DFN ok
6524a11
@martinjrobins martinjrobins mentioned this issue Feb 10, 2023
Merged
6 tasks
martinjrobins added a commit that referenced this issue Feb 10, 2023
@martinjrobins
#2643 remove unused code
65051e3
martinjrobins added a commit that referenced this issue Feb 10, 2023
@martinjrobins
#2643 docstring for idaklu add banded options
5c241ff
martinjrobins added a commit that referenced this issue Feb 10, 2023
@martinjrobins
#2643 tidy up debug code
ede7c98
martinjrobins added a commit that referenced this issue Feb 14, 2023
@martinjrobins
#2643 dont need to handle none anymore
5faa557
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinjrobins martinjrobins

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I2643 banded pybamm-team/PyBaMM
1 participant
@martinjrobins