Refactor Simulation.solve
#3176
Labels
difficulty: hard
Will take several weeks
in-progress
Assigned in the core dev monthly meeting
priority: medium
To be resolved if time allows
As part of #3101 I was looking at the
Simulation
class and noticed that the messy part is basically thesolve
method (and in particular, the experiment part). In my mind, the bigger goal here is to keepSimulation
class (without experiments) to be compatible with any model (even models beyond battery).I think that just simply refactoring the whole experiment part as a separate function would help a lot (maybe with an extra check of whether a given model supports experiments or not). The other main point I would like to discuss here is whether we deprecate the
"drive cycle"
mode, given that now this can easily be done with the experiment steps.TLDR What I propose here is:
"drive cycle"
mode in theSimulation
(already supported via experiment)."without experiment"
mode works with any model (even those custom defined).The text was updated successfully, but these errors were encountered: