Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for when only a subset of input params are used for sensitivities #1897

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

martinjrobins
Copy link
Contributor

Fixes #1887

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@martinjrobins martinjrobins marked this pull request as ready for review January 12, 2022 12:45
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1897 (b8e097e) into develop (278b9f7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
- Coverage    99.35%   99.35%   -0.01%     
===========================================
  Files          346      346              
  Lines        18999    18972      -27     
===========================================
- Hits         18876    18849      -27     
  Misses         123      123              
Impacted Files Coverage Δ
pybamm/experiments/experiment.py 100.00% <ø> (ø)
...models/full_battery_models/lead_acid/basic_full.py 100.00% <ø> (ø)
...ybamm/models/full_battery_models/lead_acid/loqs.py 100.00% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_spm.py 100.00% <ø> (ø)
...tery_models/lithium_ion/electrode_soh_half_cell.py 100.00% <ø> (ø)
pybamm/discretisations/discretisation.py 99.79% <100.00%> (ø)
...bamm/expression_tree/operations/replace_symbols.py 100.00% <100.00%> (ø)
pybamm/models/base_model.py 99.23% <100.00%> (-0.02%) ⬇️
...m/models/full_battery_models/base_battery_model.py 99.76% <100.00%> (-0.01%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804ea24...b8e097e. Read the comment docs.

@martinjrobins martinjrobins changed the title #1887 fix for when only a subset of input params are used for sensitivities fix for when only a subset of input params are used for sensitivities Jan 12, 2022
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see suggestion for additional test

CHANGELOG.md Outdated Show resolved Hide resolved
tests/unit/test_solvers/test_casadi_solver.py Outdated Show resolved Hide resolved
@martinjrobins martinjrobins merged commit b112fd7 into develop Mar 14, 2022
@martinjrobins martinjrobins deleted the i1887-sens-subset branch March 14, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAE Multiple inputs with fewer sensitivites
3 participants