Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to save which last pybamm commit #2293

Merged
merged 6 commits into from
Sep 13, 2022
Merged

Conversation

valentinsulzer
Copy link
Member

Description

Function saves information about the commit, and if that is not available it returns the version number

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #2293 (8026dac) into develop (2c60416) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2293   +/-   ##
========================================
  Coverage    99.40%   99.40%           
========================================
  Files          364      364           
  Lines        20021    20037   +16     
========================================
+ Hits         19901    19917   +16     
  Misses         120      120           
Impacted Files Coverage Δ
pybamm/__init__.py 100.00% <ø> (ø)
pybamm/batch_study.py 100.00% <ø> (ø)
pybamm/spatial_methods/finite_volume.py 98.15% <ø> (ø)
pybamm/spatial_methods/spatial_method.py 96.36% <ø> (ø)
pybamm/expression_tree/functions.py 100.00% <100.00%> (ø)
pybamm/spatial_methods/scikit_finite_element.py 98.85% <100.00%> (ø)
pybamm/util.py 100.00% <100.00%> (ø)
pybamm/models/submodels/interface/sei/base_sei.py 100.00% <0.00%> (ø)
...ybamm/models/submodels/interface/base_interface.py 100.00% <0.00%> (ø)
...m/models/full_battery_models/base_battery_model.py 99.78% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@priyanshuone6 priyanshuone6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@valentinsulzer valentinsulzer merged commit 256da26 into develop Sep 13, 2022
@valentinsulzer valentinsulzer deleted the save-git-commit branch September 15, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants