Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove external_variables #2502

Merged
merged 17 commits into from
Dec 13, 2022
Merged

remove external_variables #2502

merged 17 commits into from
Dec 13, 2022

Conversation

TomTranter
Copy link
Contributor

Description

Remove external_variables which have functionality that is now completely replicable with input parameters. Motivation is to simplify code and reduce redundant functionality. Also relates to a liionpack issue with handling the two types of data seperately and is cleaner to use inputs.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 99.72% // Head: 99.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bff1f46) compared to base (97e2785).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #2502    +/-   ##
=========================================
  Coverage    99.72%   99.73%            
=========================================
  Files          270      270            
  Lines        19487    19360   -127     
=========================================
- Hits         19434    19308   -126     
+ Misses          53       52     -1     
Impacted Files Coverage Δ
pybamm/expression_tree/exceptions.py 100.00% <ø> (ø)
...mm/expression_tree/operations/convert_to_casadi.py 100.00% <ø> (ø)
pybamm/expression_tree/variable.py 100.00% <ø> (ø)
...full_battery_models/equivalent_circuit/thevenin.py 100.00% <ø> (ø)
pybamm/models/submodels/base_submodel.py 100.00% <ø> (ø)
pybamm/parameters/parameter_values.py 100.00% <ø> (ø)
pybamm/solvers/casadi_solver.py 99.66% <ø> (ø)
pybamm/solvers/idaklu_solver.py 99.06% <ø> (ø)
pybamm/spatial_methods/finite_volume.py 98.14% <ø> (-0.02%) ⬇️
pybamm/spatial_methods/spatial_method.py 96.29% <ø> (-0.07%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing changes look good but there are more lines to remove, see coverage

@TomTranter
Copy link
Contributor Author

@tinosulzer tests passing but some benchmarks are failing. How can I run just the failing ones locally easily?

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TomTranter

@valentinsulzer valentinsulzer merged commit ea1f675 into develop Dec 13, 2022
@valentinsulzer valentinsulzer deleted the remove_external_variables branch December 13, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants