Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to calculate theoretical efficiency #2777

Merged
merged 6 commits into from
Mar 15, 2023

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Mar 15, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Implements integral of VdQ to calculate theoretical maximum energy. Useful for defining battery efficiency. Submitted PR due to discussion with @tinosulzer

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • [ x] New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (124efe5) 99.68% compared to head (617549c) 99.68%.

❗ Current head 617549c differs from pull request most recent head 0fa49e2. Consider uploading reports for the commit 0fa49e2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2777   +/-   ##
========================================
  Coverage    99.68%   99.68%           
========================================
  Files          272      272           
  Lines        19007    19027   +20     
========================================
+ Hits         18948    18968   +20     
  Misses          59       59           
Impacted Files Coverage Δ
...s/full_battery_models/lithium_ion/electrode_soh.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some formatting changes, also what is 26.8 ?

@valentinsulzer valentinsulzer merged commit c0d394e into pybamm-team:develop Mar 15, 2023
@aabills aabills deleted the batt-carnot branch March 15, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants