Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2457 make jupyter a dev only dependency #2846

Merged
merged 16 commits into from
Apr 3, 2023
Merged

Issue #2457 make jupyter a dev only dependency #2846

merged 16 commits into from
Apr 3, 2023

Commits on Mar 30, 2023

  1. Removed Jupyter from requirements.txt

    @arjxn-py
    arjxn-py committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    9c5fe35 View commit details
    Browse the repository at this point in the history

  2. Moved Jupyter from required deps to Dev Deps

    @arjxn-py
    arjxn-py committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1ba8b5c View commit details
    Browse the repository at this point in the history

  3. Listed importlib-metadata as req dependency

    @arjxn-py
    arjxn-py committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    8e5bd4c View commit details
    Browse the repository at this point in the history

  4. Listed nbconvert as req dependency

    @arjxn-py
    arjxn-py committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    ecade1e View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Merge branch 'pybamm-team:develop' into Issue-pybamm-team#2457-Make-j… 

    …upyter-a-dev-only-dependency
    @arjxn-py
    arjxn-py committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    1dec74e View commit details
    Browse the repository at this point in the history

  2. installing jupyter in iox.ini

    @arjxn-py
    arjxn-py committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    b0bcadd View commit details
    Browse the repository at this point in the history

  3. installing jupyter in tox.ini

    @arjxn-py
    arjxn-py committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    3b04513 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'Issue-pybamm-team#2457-Make-jupyter-a-dev-only-dependen… 

    …cy' of https://github.com/arjxn-py/PyBaMM into Issue-pybamm-team#2457-Make-jupyter-a-dev-only-dependency
    @arjxn-py
    arjxn-py committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    805199b View commit details
    Browse the repository at this point in the history

  5. installing jupyter to run example tests

    @arjxn-py
    arjxn-py committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    fbeec0d View commit details
    Browse the repository at this point in the history

  6. make jupyter a dev dep in tox.ini

    @arjxn-py
    arjxn-py committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    9ac57de View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. Trying to resolve linux build error

    @arjxn-py
    arjxn-py committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    346b06b View commit details
    Browse the repository at this point in the history

  2. made nbconvert a dev dependency

    @arjxn-py
    arjxn-py committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    7bb578c View commit details
    Browse the repository at this point in the history

  3. style: pre-commit fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    aa2744d View commit details
    Browse the repository at this point in the history

  4. removed explicit listing of nbconvert from tox.ini

    @arjxn-py
    arjxn-py committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    976df86 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
    @arjxn-py @Saransh-cpp
    arjxn-py and Saransh-cpp committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    68eb624 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Updated changelog for the same PR

    @arjxn-py
    arjxn-py committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    ba89a07 View commit details
    Browse the repository at this point in the history