-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add self-hosted actions to periodic tests #2929
Add self-hosted actions to periodic tests #2929
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2929 +/- ##
========================================
Coverage 99.71% 99.71%
========================================
Files 248 248
Lines 18749 18749
========================================
Hits 18695 18695
Misses 54 54 ☔ View full report in Codecov by Sentry. |
This is ready to merge now @martinjrobins. Here's an overview:
We will be relocating the runner onto a separate network in the very near future, but it would be good to validate this workflow ahead of that, so it might just go offline for a day or two during that migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging the nox PR generated conflicts with a lot of open PRs 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @BradyPlanden, couple of suggestions below, and add @Saransh-cpp's changes as well
90e5bc6
to
5e28bb9
Compare
Thanks @martinjrobins and @Saransh-cpp, this is updated now and should be good for another review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BradyPlanden , happy to merge this now :)
Description
This updates the
run_periodic_tests.yml
workflow to include the self-hosted m-series runner.Fixes #2884
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
$ python run-tests.py --doctest
You can run unit and doctests together at once, using
$ python run-tests.py --quick
.Further checks: