Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backport importlib_metadata from required dependencies #3050

Merged

Conversation

agriyakhetarpal
Copy link
Member

Description

A quick fix to replace the dependency on the backported module importlib_metadata with the standard module importlib.metadata, since we had dropped support for Python 3.7 and below in #2370

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@agriyakhetarpal agriyakhetarpal marked this pull request as draft June 19, 2023 10:37
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (abc53f5) 99.71% compared to head (9623c9b) 99.71%.

❗ Current head 9623c9b differs from pull request most recent head facd037. Consider uploading reports for the commit facd037 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3050   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18736    18736           
========================================
  Hits         18682    18682           
  Misses          54       54           
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@agriyakhetarpal agriyakhetarpal marked this pull request as ready for review June 19, 2023 12:12
@valentinsulzer valentinsulzer merged commit 48e81e3 into pybamm-team:develop Jun 19, 2023
15 of 16 checks passed
@agriyakhetarpal agriyakhetarpal deleted the remove-importlib-backport branch June 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants