Raise error for unknown parameter_values

[tommaull]

added else statement to inform user of an invalid parameter set

Description

Added else statement to inform user of an invalid parameter set in parameter_values.py

In response to #3063 - Raise error for unknown parameter sets

Fixes # (3063)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all
• The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[tommaull]

Ran unit tests, FAILED (failures=1, skipped=62)
FAIL: test_symbol_visualise (test_expression_tree.test_symbol.TestSymbol)

Traceback (most recent call last):
File "C:\Users\tom.maull\Desktop\PybammDev\PyBaMM\tests\testcase.py", line 29, in wrapped
return method(*args, **kwargs)
File "C:\Users\tom.maull\Desktop\PybammDev\PyBaMM\tests\unit\test_expression_tree\test_symbol.py", line 393, in test_symbol_visualise
self.assertTrue(os.path.exists("test_visualize.png"))
AssertionError: False is not true

[tommaull]

Doc test result:
(pybamm) C:\Users\tom.maull\Desktop\PybammDev\PyBaMM>python run-tests.py --doctest
Checking if docs can be built.
Traceback (most recent call last):
File "C:\Users\tom.maull\Desktop\PybammDev\PyBaMM\run-tests.py", line 427, in
run_doc_tests()
File "C:\Users\tom.maull\Desktop\PybammDev\PyBaMM\run-tests.py", line 68, in run_doc_tests
p = subprocess.Popen(
File "C:\Users\tom.maull\AppData\Local\mambaforge\envs\pybamm\lib\subprocess.py", line 951, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "C:\Users\tom.maull\AppData\Local\mambaforge\envs\pybamm\lib\subprocess.py", line 1420, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified

[rtimms]

Thanks for taking this on! After you've updated the code to raise an error can you also add a test in this file to confirm the error is raised when it should be. See here for an example.

The errors you are seeing locally are unrelated.

[rtimms]

could you raise a ValueError here? E.g.

else:
    raise ValueError("helpful message")

[tommaull]

Done

[rtimms]

thanks @tommaull looks good!

[rtimms]

@all-contributors please add @tommaull for code and tests

[allcontributors]

@rtimms

I've put up a pull request to add @tommaull! 🎉

[rtimms]

@tommaull sorry, forgot to say, could you also add an entry to the changelog? thanks!

[tommaull]

changelog updated - sorry about that!

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5486fce) 99.71% compared to head (10f9f46) 99.71%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3132   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18747    18748    +1     
========================================
+ Hits         18693    18694    +1     
  Misses          54       54           

Impacted Files	Coverage Δ
pybamm/parameters/parameter_values.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.