Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SEI example notebook #3166

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix SEI example notebook #3166

merged 1 commit into from
Jul 20, 2023

Conversation

brosaplanella
Copy link
Sponsor Member

Fix the failing notebook, as identified in #3110 (comment). I also wrote some extra details about how to fix the moving boundary, which were part of the non-dimensionalisation and thus were lost with the shift to dimensional models.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@brosaplanella
Copy link
Sponsor Member Author

@arjxn-py this should fix the problems with #3110, so once we merge this into develop you can merge develop back into your branch.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f1f3fe5) 99.71% compared to head (7c86beb) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3166   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18751    18751           
========================================
  Hits         18697    18697           
  Misses          54       54           
Impacted Files Coverage Δ
pybamm/parameters/lithium_ion_parameters.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arjxn-py
Copy link
Member

arjxn-py commented Jul 20, 2023

@arjxn-py this should fix the problems with #3110, so once we merge this into develop you can merge develop back into your branch.

Thanks so much @brosaplanella 😄, will merge my branch with it.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @brosaplanella looks good to me!

@brosaplanella brosaplanella merged commit 2b51c32 into develop Jul 20, 2023
19 of 21 checks passed
@brosaplanella brosaplanella deleted the fix-example-SEI branch July 20, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants