Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow double-layer capacitance to depend on temperature #3174

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

valentinsulzer
Copy link
Member

Description

allow double-layer capacitance to depend on temperature

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f1f3fe5) 99.71% compared to head (53b8a52) 99.71%.

❗ Current head 53b8a52 differs from pull request most recent head 039c786. Consider uploading reports for the commit 039c786 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3174   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18751    18761   +10     
========================================
+ Hits         18697    18707   +10     
  Misses          54       54           
Impacted Files Coverage Δ
pybamm/models/submodels/electrode/ohm/li_metal.py 100.00% <100.00%> (ø)
...ential_form/composite_surface_form_conductivity.py 97.95% <100.00%> (+0.04%) ⬆️
...e_potential_form/full_surface_form_conductivity.py 100.00% <100.00%> (ø)
...otential_form/leading_surface_form_conductivity.py 100.00% <100.00%> (ø)
pybamm/parameters/lead_acid_parameters.py 100.00% <100.00%> (ø)
pybamm/parameters/lithium_ion_parameters.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer merged commit e843d80 into develop Jul 21, 2023
18 of 20 checks passed
@valentinsulzer valentinsulzer deleted the capacitance-temperature branch July 21, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants