Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3128 spme psd #3207

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Issue 3128 spme psd #3207

merged 5 commits into from
Jul 31, 2023

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jul 31, 2023

Description

Particle size distributions now work with SPMe and NewmanTobias models.

EDIT: Also fixed BasicSPM, BasicDFN and BasicDFNComposite here (added it by mistake but might as well leave it). See this discussion for details.

Fixes #3128

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinsulzer valentinsulzer merged commit de64f2e into develop Jul 31, 2023
17 of 20 checks passed
@valentinsulzer valentinsulzer deleted the issue-3128-spme-psd branch July 31, 2023 15:12
@rtimms rtimms mentioned this pull request Jul 31, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SPMe with particle size distribution
2 participants