-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for cylindrical and spherical shell domains #3237
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8949068
Merge branch 'issue-3200-2D-processed-variables' into issue-3115-shel…
brosaplanella afd43d1
#3115 enable shell domains
brosaplanella d0c666c
#3115 integration tests added
brosaplanella 2a26d12
Merge branch 'issue-3200-2D-processed-variables' into issue-3115-shel…
brosaplanella 9cf205d
#3115 update CHANGELOG
brosaplanella ca0303b
style: pre-commit fixes
pre-commit-ci[bot] 88e4fbd
Merge branch 'issue-3200-2D-processed-variables' into issue-3115-shel…
brosaplanella 6e4d472
Merge branch 'issue-3115-shell-domains' of github.com:pybamm-team/PyB…
brosaplanella 091bb99
Merge branch 'issue-3200-2D-processed-variables' into issue-3115-shel…
brosaplanella dba86bf
Merge branch 'issue-3200-2D-processed-variables' into issue-3115-shel…
brosaplanella 67dcb1c
Merge branch 'develop' into issue-3115-shell-domains
brosaplanella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit strange to have a solver inside this test. Not the end of the world but would be better without, so that this is really a unit test (and not dependent on the solver). Is there another way to test the same thing?