Issue 3323 - electrode thickness change [m]

[bobonice]

Description

Fixed a bug that caused the absence of dimension for the variable electrode_thickness_change in the class BaseMechanics (base_mechanics.py).

• In reference to the previous version, the following codes were added to obtain the right results of "{Domain} electrode thickness change [m]":
  L0 = domain_param.L
electrode_thickness_change = self.param.n_electrodes_parallel * v_change * L0
• Correspondingly, Figure 1 in the tutorial "Validating_mechanical_models_Enertech_DFN.ipynb” was updated.

Fixes # (3323)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[rtimms]

thanks @bobonice! could you please add an entry to the changelog ?

[rtimms]

@all-contributors please add @bobonice for bug report and code

[allcontributors]

@rtimms

I've put up a pull request to add @bobonice! 🎉

[bobonice]

Thanks @rtimms! The change (include PR #) has been updated to the CHANGELOG.md.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ec5383c) 99.70% compared to head (e8b56ae) 99.70%.
Report is 64 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3329   +/-   ##
========================================
  Coverage    99.70%   99.70%           
========================================
  Files          248      248           
  Lines        18899    18900    +1     
========================================
+ Hits         18844    18845    +1     
  Misses          55       55           

Files Changed	Coverage Δ
...els/submodels/particle_mechanics/base_mechanics.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.