Drop support for i686 manylinux #3412

agriyakhetarpal · 2023-10-05T11:32:00Z

Description

Drops support for 32-bit wheels on Linux platforms due to NumPy's recent BLAS requirement and uses an updated method, i.e., python -m build for building the source distribution

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

New feature (non-breaking change which adds functionality)
Optimization (back-end change that speeds up the code)
Bug fix (non-breaking change which fixes an issue)

Key checklist:

No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
All tests pass: $ python run-tests.py --all (or $ nox -s tests)
The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

Code is commented, particularly in hard-to-understand areas
Tests added that prove fix is effective or that feature works

because it was already dropped for Windows earlier

agriyakhetarpal · 2023-10-05T11:35:19Z

Not sure how to move the release tag but the PyPI job can be triggered from the develop branch this time after this is merged

Saransh-cpp

Looks good, thanks, @agriyakhetarpal!

.github/workflows/publish_pypi.yml

Co-authored-by: Saransh Chopra <saransh0701@gmail.com>

codecov · 2023-10-05T12:10:49Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (66742b2) 99.58% compared to head (245a3fa) 99.58%.
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3412   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          256      256           
  Lines        19998    19998           
========================================
  Hits         19915    19915           
  Misses          83       83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/publish_pypi.yml

Saransh-cpp · 2023-10-05T13:21:09Z

Sorry, took over 🙂

Passing wheels - https://github.com/Saransh-cpp/PyBaMM/actions/runs/6419549705/job/17429623189

agriyakhetarpal · 2023-10-05T13:47:25Z

No worries! Let's hope Windows wheels pass too!

…-support Drop support for i686 manylinux

* Bump to v23.9rc0 * Merge pull request #3412 from agriyakhetarpal/drop-i686-manylinux2014-support Drop support for i686 manylinux * Merge pull request #3413 from Saransh-cpp/improve-release-workflow Improve release workflow, add a note, bump version manually * Merge pull request #3436 from Saransh-cpp/fortnightly-wheels Build wheels on the 1st and 15th of every month * Merge pull request #3445 from pybamm-team/issue-3428-rename-exchange #3428 exchange-current density error * Merge pull request #3449 from pybamm-team/i3431-windows-wheels Fix failing windows wheel builds * Merge pull request #3456 from abillscmu/issue-3224-initial_soc make initial soc work with half cell models * Merge pull request #3467 from abillscmu/bugfix/initial_soh * Merge pull request #3423 from jsbrittain/jax_gpu JaxSolver fails when using GPU support with no input parameters * Fix changelog * Merge pull request #3475 from arjxn-py/fix-default-imports Resolve default imports for optional dependencies * Bump - `v23.9rc1` * Fix date in CHANGELOG * Bump version to v23.9 * Fix docs about Jax solver compatibility with Python versions (#3702) * Ensure correct Python versions for Jax solver compatibility * Simplify array of Python versions Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Use different conjunction Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Merge pull request #3706 from agriyakhetarpal/fix-pybamm-install-odes Make `pybamm_install_odes` a bit more robust * #3690 fix issue with skipped steps (#3708) * #3690 fix issue with skipped steps * #3690 changelog * #3690 add test * #3611 use actual cell volume for average total heating (#3707) * #3611 use actual cell volume for average total heating * #3611 changelog * #3611 account for number of electrode pairs * #3611 update variable names * Improve the release workflow (#3737) * Try fixing the release workflow * Turn off safety * Fix CHANGELOG * Add OS * Use regex for better matches * Update instructions, add safety checks * checkout to the version branch for the final release * Bump to v24.1rc1 * #3630 fix interpolant shape error (#3761) * #3630 fix interpolant shape error * #3630 changelog * Bump to v24.1rc2 * Bump to v24.1 * Fix doctests failures in scheduled tests (#3784) Closes #3781 * Resolve broken `scikits.odes` installation on self-hosted M-series runner (#3785) * Try fixing M-series runner tests This is being done by adding SuiteSparse and SUNDIALS installations which might have been missing on the runner, which broke `scikits.odes`. * Don't use Homebrew SUNDIALS, use LD_LIBRARY_PATH * Don't use Homebrew to install SUNDIALS * Force remove pip cache for `scikits.odes` --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * add temperature dependence to MSMR model * changelog * fix tests * fix example * rob comments * update notebook --------- Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk> Co-authored-by: Saransh Chopra <saransh0701@gmail.com> Co-authored-by: Martin Robinson <martinjrobins@gmail.com> Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com> Co-authored-by: Saransh-cpp <Saransh-cpp@users.noreply.github.com>

* Bump to v23.9rc0 * Merge pull request pybamm-team#3412 from agriyakhetarpal/drop-i686-manylinux2014-support Drop support for i686 manylinux * Merge pull request pybamm-team#3413 from Saransh-cpp/improve-release-workflow Improve release workflow, add a note, bump version manually * Merge pull request pybamm-team#3436 from Saransh-cpp/fortnightly-wheels Build wheels on the 1st and 15th of every month * Merge pull request pybamm-team#3445 from pybamm-team/issue-3428-rename-exchange pybamm-team#3428 exchange-current density error * Merge pull request pybamm-team#3449 from pybamm-team/i3431-windows-wheels Fix failing windows wheel builds * Merge pull request pybamm-team#3456 from abillscmu/issue-3224-initial_soc make initial soc work with half cell models * Merge pull request pybamm-team#3467 from abillscmu/bugfix/initial_soh * Merge pull request pybamm-team#3423 from jsbrittain/jax_gpu JaxSolver fails when using GPU support with no input parameters * Fix changelog * Merge pull request pybamm-team#3475 from arjxn-py/fix-default-imports Resolve default imports for optional dependencies * Bump - `v23.9rc1` * Fix date in CHANGELOG * Bump version to v23.9 * Fix docs about Jax solver compatibility with Python versions (pybamm-team#3702) * Ensure correct Python versions for Jax solver compatibility * Simplify array of Python versions Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Use different conjunction Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Merge pull request pybamm-team#3706 from agriyakhetarpal/fix-pybamm-install-odes Make `pybamm_install_odes` a bit more robust * pybamm-team#3690 fix issue with skipped steps (pybamm-team#3708) * pybamm-team#3690 fix issue with skipped steps * pybamm-team#3690 changelog * pybamm-team#3690 add test * pybamm-team#3611 use actual cell volume for average total heating (pybamm-team#3707) * pybamm-team#3611 use actual cell volume for average total heating * pybamm-team#3611 changelog * pybamm-team#3611 account for number of electrode pairs * pybamm-team#3611 update variable names * Improve the release workflow (pybamm-team#3737) * Try fixing the release workflow * Turn off safety * Fix CHANGELOG * Add OS * Use regex for better matches * Update instructions, add safety checks * checkout to the version branch for the final release * Bump to v24.1rc1 * pybamm-team#3630 fix interpolant shape error (pybamm-team#3761) * pybamm-team#3630 fix interpolant shape error * pybamm-team#3630 changelog * Bump to v24.1rc2 * Bump to v24.1 * Fix doctests failures in scheduled tests (pybamm-team#3784) Closes pybamm-team#3781 * Resolve broken `scikits.odes` installation on self-hosted M-series runner (pybamm-team#3785) * Try fixing M-series runner tests This is being done by adding SuiteSparse and SUNDIALS installations which might have been missing on the runner, which broke `scikits.odes`. * Don't use Homebrew SUNDIALS, use LD_LIBRARY_PATH * Don't use Homebrew to install SUNDIALS * Force remove pip cache for `scikits.odes` --------- Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * add temperature dependence to MSMR model * changelog * fix tests * fix example * rob comments * update notebook --------- Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk> Co-authored-by: Saransh Chopra <saransh0701@gmail.com> Co-authored-by: Martin Robinson <martinjrobins@gmail.com> Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com> Co-authored-by: Saransh-cpp <Saransh-cpp@users.noreply.github.com>

agriyakhetarpal added 2 commits October 5, 2023 16:56

Drop support for i686 manylinux, use build for sdist

f8049a5

Update changelog about dropping 32-bit Linux support

390b47f

because it was already dropped for Windows earlier

agriyakhetarpal requested review from Saransh-cpp and martinjrobins October 5, 2023 11:35

Saransh-cpp approved these changes Oct 5, 2023

View reviewed changes

.github/workflows/publish_pypi.yml Outdated Show resolved Hide resolved

Remove comments and notes about BLAS

319d0b4

Co-authored-by: Saransh Chopra <saransh0701@gmail.com>

Saransh-cpp requested changes Oct 5, 2023

View reviewed changes

.github/workflows/publish_pypi.yml Outdated Show resolved Hide resolved

Saransh-cpp added 2 commits October 5, 2023 18:28

Bump SuiteSparse to 6.0.3

0893769

Try fixing KLU paths

245a3fa

Saransh-cpp approved these changes Oct 5, 2023

View reviewed changes

Saransh-cpp merged commit 8f06bc1 into pybamm-team:develop Oct 5, 2023
34 of 35 checks passed

agriyakhetarpal deleted the drop-i686-manylinux2014-support branch October 5, 2023 14:21

Saransh-cpp added a commit that referenced this pull request Oct 17, 2023

Merge pull request #3412 from agriyakhetarpal/drop-i686-manylinux2014…

50be8a5

…-support Drop support for i686 manylinux

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop support for i686 manylinux #3412

Drop support for i686 manylinux #3412

agriyakhetarpal commented Oct 5, 2023 •

edited

Loading

agriyakhetarpal commented Oct 5, 2023

Saransh-cpp left a comment

codecov bot commented Oct 5, 2023 •

edited

Loading

Saransh-cpp commented Oct 5, 2023

agriyakhetarpal commented Oct 5, 2023

Drop support for i686 manylinux #3412

Drop support for i686 manylinux #3412

Conversation

agriyakhetarpal commented Oct 5, 2023 • edited Loading

Description

Type of change

Key checklist:

Further checks:

agriyakhetarpal commented Oct 5, 2023

Saransh-cpp left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 5, 2023 • edited Loading

Codecov Report

Saransh-cpp commented Oct 5, 2023

agriyakhetarpal commented Oct 5, 2023

agriyakhetarpal commented Oct 5, 2023 •

edited

Loading

codecov bot commented Oct 5, 2023 •

edited

Loading