Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degradation example update #3691

Merged
merged 15 commits into from
Jan 5, 2024
Merged

Conversation

DrSOKane
Copy link
Contributor

@DrSOKane DrSOKane commented Jan 5, 2024

The experiment protocol for the coupled degradation example notebook was changed so that the 5 minute period applied to all stepts of all cycles, including the 1C discharge. This results in the simulation being unstable for large numbers of cycles. This pull request reverts the change and fixes the issue.

Fixes #3669

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good. You have some really old commits on this branch though. The other PR you closed was from your develop branch and did the same thing. My guess is that you should reset your develop branch to the main pybamm develop branch

@kratman
Copy link
Contributor

kratman commented Jan 5, 2024

The change looks good. You have some really old commits on this branch though. The other PR you closed was from your develop branch and did the same thing. My guess is that you should reset your develop branch to the main pybamm develop branch

Also you have some reverts, so it might be best to squash this PR to a single commit

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d46cbe3) 99.59% compared to head (a5f2d68) 99.59%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3691   +/-   ##
========================================
  Coverage    99.59%   99.59%           
========================================
  Files          258      258           
  Lines        20796    20796           
========================================
  Hits         20711    20711           
  Misses          85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman kratman merged commit 3bf9084 into pybamm-team:develop Jan 5, 2024
40 of 41 checks passed
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
* fixed tests

* Added graphite half-cell parameter files

* Revert "Added graphite half-cell parameter files"

This reverts commit 78001e8.

* Revert "fixed tests"

This reverts commit cf53ff1.

* Restored original experiment protocol to coupled degradation example notebook

* changelog

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants