I3790 idaklu outvars #3803
Merged
I3790 idaklu outvars #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbrittain
requested review from
martinjrobins,
rtimms,
valentinsulzer and
TomTranter
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3803 +/- ##
========================================
Coverage 99.60% 99.60%
========================================
Files 258 259 +1
Lines 21226 21287 +61
========================================
+ Hits 21142 21203 +61
Misses 84 84 ☔ View full report in Codecov by Sentry. |
pybamm/expression_tree/symbol.py
Outdated
Comment on lines
986
to
997
| def contains(self, expr_type): | ||
| """ | ||
| Does the symbol tree contain a given node type? | ||
| """ | ||
| if type(self) is expr_type: | ||
| return True | ||
| elif "children" in dir(self): | ||
| for child in self.children: | ||
| if child.contains(expr_type): | ||
| return True | ||
| return False | ||
|
|
There was a problem hiding this comment.
how is this different from has_symbol_of_classes ?
There was a problem hiding this comment.
@tinosulzer I hadn't spotted that method - I've reverted to using has_symbol_of_classes as the more pythonic implementation to avoid duplicating this behaviour.
martinjrobins
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When run with
output_variables, the IDAKLU solver does not fail gracefully when requesting a variable that was not specified in the requested variables list. Note that 'model parameters' that do not appear inoutput_variablesshould still be returned upon request.Fixes #3790
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: