Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3495 separator #3905

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Issue 3495 separator #3905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0957329
rename separator porosity to transport efficiency
valentinsulzer Mar 19, 2024
fd1bfb7
changelog
valentinsulzer Mar 19, 2024
600742f
Merge branch 'develop' into issue-3495-separator
valentinsulzer Mar 19, 2024
3b6a2df
fix typo
valentinsulzer Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

## Bug Fixes

- Fixed bug where separator porosity was used in calculation instead of transport efficiency ([#3905](https://github.com/pybamm-team/PyBaMM/pull/3905))
- Initial voltage can now match upper or lower cut-offs exactly ([#3842](https://github.com/pybamm-team/PyBaMM/pull/3842))
- Fixed a bug where 1+1D and 2+1D models would not work with voltage or power controlled experiments([#3829](https://github.com/pybamm-team/PyBaMM/pull/3829))
- Update IDAKLU solver to fail gracefully when a variable is requested that was not in the solves `output_variables` list ([#3803](https://github.com/pybamm-team/PyBaMM/pull/3803))
Expand Down
2 changes: 1 addition & 1 deletion ...bmodels/electrolyte_conductivity/surface_potential_form/full_surface_form_conductivity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def get_coupled_variables(self, variables):
else:
phi_e_n = variables["Negative electrolyte potential [V]"]
phi_e_n_s = pybamm.boundary_value(phi_e_n, "right")
tor_s = variables["Separator porosity"]
tor_s = variables["Separator electrolyte transport efficiency"]
T = variables["Separator temperature [K]"]

chiRT_over_Fc_e_s = param.chiRT_over_Fc(c_e_s, T)
Expand Down
Loading