-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage workflow #4146
Fix coverage workflow #4146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: we should move the coverage upload step above the integration tests, since the coverage is just for the unit tests anyway – CodeCov will then analyse the coverage and return its results earlier
The notebook failure is sporadic and unrelated, should be fixed with a rerun |
Another proposition: the |
For now, lets leave it. Especially if it requires skipping some coverage tests |
The coverage upload failed silently again, maybe we need to supply GHA's special |
|
I think someone with admin permissions will have to add a secret to the repository, then – tagging @pybamm-team/maintainers |
I think it an issue with codecov because I am using a fork for my branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4146 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 288 288
Lines 21790 21790
========================================
Hits 21693 21693
Misses 97 97 ☔ View full report in Codecov by Sentry. |
Works now, sporadic failures will happen until the codecov fixes a bug |
* Remove quotes from the if-statement * Adjust logic * Fix job naming * Change order
Description
Coverage was not working properly, this should fix it
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: