Removing `run-tests.py` file. #4180

prady0t · 2024-06-14T16:34:30Z

Description

Trying to remove run-tests.py file.

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

prady0t · 2024-06-14T16:35:38Z

Yet to add conftest.py file

codecov · 2024-06-14T16:55:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (ed412f8) to head (3075a77).
Report is 6 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4180   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files          288      288           
  Lines        22089    22092    +3     
========================================
+ Hits         21969    21972    +3     
  Misses         120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

agriyakhetarpal

This is looking good! I tried locally and

==================================================================== 44 passed in 100.46s (0:01:40) ====================================================================
nox > Session scripts was successful.

much faster than the serial implementation. I checked and the slowest scripts are run_ecm.py, experiment_drive_cycle.py, and pouch_cell_cooling.py. It might be worth improving those, but I guess 100 seconds for 44 scripts isn't too bad at all, afterall, and is rather great in terms of speedups.

noxfile.py

tests/test_examples.py

noxfile.py

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

prady0t · 2024-06-15T12:47:59Z

I think I messed up the branch. I'm having problems while pushing changes. I've made the changes for now.

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

agriyakhetarpal · 2024-07-10T08:58:55Z

@prady0t, could you fix the failure in the style jobs so that the tests can run?

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

…into removing-runtest Solving merge conflicts.

prady0t · 2024-07-10T09:49:22Z

@prady0t, could you fix the failure in the style jobs so that the tests can run?

Done. I removed lot of code lines from conftest.py file and now we are using -m for everything. If a user runs pytest without any marker value, it runs all the tests, otherwise only those specified by -m flag.

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

…into removing-runtest Merging

prady0t · 2024-07-14T20:11:05Z

Added documentation fixes.

CONTRIBUTING.md

tests/test_scripts.py

CONTRIBUTING.md

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

tests/test_scripts.py

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

…into removing-runtest Merging.

agriyakhetarpal

Thanks for your work here, @prady0t! This looks great now – just a couple of comments, and this is ready to go.

CONTRIBUTING.md

pyproject.toml

agriyakhetarpal · 2024-07-26T17:23:42Z

This will need approval from @arjxn-py since he previously requested changes, we can merge after that

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

arjxn-py

This looks good, thanks @prady0t.
Will just wait for CI to pass to observe logs once, then we can merge.

agriyakhetarpal · 2024-07-26T18:32:49Z

No unnecessary logs this time around: https://github.com/pybamm-team/PyBaMM/actions/runs/10115401416/job/27976388229

arjxn-py · 2024-07-26T18:36:12Z

No unnecessary logs this time around: https://github.com/pybamm-team/PyBaMM/actions/runs/10115401416/job/27976388229

Noticed that, just that we'd need to update branch to merge. My bad, I should have done it earlier.

* Removing run-test.py file Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Update test_examples.py * Update noxfile.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Removing run-test.py file Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing example marker Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * adding conftest.py file Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * adding back changes Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Update test_examples.py * style: pre-commit fixes * Removing run-test.py file Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removing redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Update test_examples.py * Update noxfile.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * adding back changes Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * removing loop for file discovery Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * removing loop for file discovery Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Adding more flags to pytest Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Adding markers for unit and integration tests Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Adding markers for unit and integration tests Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Added back assertDomainEqual Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Added fixture for debug mode Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * Removed style failures Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Removed style failures Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Update conftest.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * style: pre-commit fixes * Update conftest.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update noxfile.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update pyproject.toml Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/testcase.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/test_scripts.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/test_scripts.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * style: pre-commit fixes * using -m instead of args Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * removed redundent files Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * fixing style failure Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * adding documentation changes Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * adding suggestions Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * removing -s flag and getting file names in scripts log Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Update pyproject.toml Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> --------- Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com> Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

prady0t added 3 commits June 14, 2024 21:57

Removing run-test.py file

a38622a

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing redundent files

b20c31d

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing redundent files

2c69d61

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

prady0t requested review from martinjrobins, Saransh-cpp, agriyakhetarpal, kratman and arjxn-py as code owners June 14, 2024 16:34

prady0t marked this pull request as draft June 14, 2024 16:34

pre-commit-ci bot and others added 3 commits June 14, 2024 16:35

style: pre-commit fixes

f762ba1

Merge branch 'develop' into removing-runtest

d4b5cff

Update test_examples.py

7961707

agriyakhetarpal reviewed Jun 14, 2024

View reviewed changes

noxfile.py Outdated Show resolved Hide resolved

tests/test_examples.py Outdated Show resolved Hide resolved

noxfile.py Outdated Show resolved Hide resolved

prady0t and others added 11 commits June 15, 2024 00:03

Update noxfile.py

4ef0462

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

Removing run-test.py file

5164a03

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing redundent files

ce862b4

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing redundent files

44085cb

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing example marker

71b7008

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

adding conftest.py file

b48392e

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Solved merge conflicts

b3ff477

adding back changes

5f3ff1d

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

style: pre-commit fixes

3fa3e72

Update test_examples.py

8c6579a

style: pre-commit fixes

d854f38

prady0t added 3 commits June 16, 2024 08:56

Removing run-test.py file

9d564ac

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing redundent files

628c14b

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Removing redundent files

5f1d606

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

prady0t and others added 2 commits July 10, 2024 12:10

removed redundent files

6aaac02

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

style: pre-commit fixes

e6dd193

prady0t and others added 3 commits July 10, 2024 15:15

fixing style failure

40212a4

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Merge branch 'removing-runtest' of https://github.com/prady0t/PyBaMM …

d813c77

…into removing-runtest Solving merge conflicts.

style: pre-commit fixes

2fde5c6

prady0t added 2 commits July 15, 2024 01:39

adding documentation changes

c9bbea5

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Merge branch 'removing-runtest' of https://github.com/prady0t/PyBaMM …

7ca4f0c

…into removing-runtest Merging

agriyakhetarpal reviewed Jul 15, 2024

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

tests/test_scripts.py Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

prady0t and others added 5 commits July 15, 2024 14:58

Update CONTRIBUTING.md

a50dd9b

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

Update CONTRIBUTING.md

516a3fb

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

Merge branch 'develop' into removing-runtest

2b03f87

adding suggestions

0cd7641

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Merge branch 'develop' into removing-runtest

c210da2

arjxn-py requested changes Jul 22, 2024

View reviewed changes

tests/test_scripts.py Outdated Show resolved Hide resolved

prady0t added 2 commits July 26, 2024 08:27

removing -s flag and getting file names in scripts log

2b4c07c

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

Merge branch 'removing-runtest' of https://github.com/prady0t/PyBaMM …

312a175

…into removing-runtest Merging.

agriyakhetarpal approved these changes Jul 26, 2024

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

prady0t and others added 2 commits July 26, 2024 23:12

Update pyproject.toml

20e223f

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

Update CONTRIBUTING.md

3075a77

Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>

arjxn-py approved these changes Jul 26, 2024

View reviewed changes

Merge branch 'develop' into removing-runtest

e321ede

arjxn-py merged commit 48b4e48 into pybamm-team:develop Jul 26, 2024
23 of 24 checks passed

kratman mentioned this pull request Jul 26, 2024

Sync develop with v24.5 #4295

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing `run-tests.py` file. #4180

Removing `run-tests.py` file. #4180

prady0t commented Jun 14, 2024

prady0t commented Jun 14, 2024

codecov bot commented Jun 14, 2024 •

edited

Loading

agriyakhetarpal left a comment

prady0t commented Jun 15, 2024 •

edited

Loading

agriyakhetarpal commented Jul 10, 2024

prady0t commented Jul 10, 2024

prady0t commented Jul 14, 2024

agriyakhetarpal left a comment

agriyakhetarpal commented Jul 26, 2024

arjxn-py left a comment

agriyakhetarpal commented Jul 26, 2024

arjxn-py commented Jul 26, 2024

Removing run-tests.py file. #4180

Removing run-tests.py file. #4180

Conversation

prady0t commented Jun 14, 2024

Description

prady0t commented Jun 14, 2024

codecov bot commented Jun 14, 2024 • edited Loading

Codecov Report

agriyakhetarpal left a comment

Choose a reason for hiding this comment

prady0t commented Jun 15, 2024 • edited Loading

agriyakhetarpal commented Jul 10, 2024

prady0t commented Jul 10, 2024

prady0t commented Jul 14, 2024

agriyakhetarpal left a comment

Choose a reason for hiding this comment

agriyakhetarpal commented Jul 26, 2024

arjxn-py left a comment

Choose a reason for hiding this comment

agriyakhetarpal commented Jul 26, 2024

arjxn-py commented Jul 26, 2024

Removing `run-tests.py` file. #4180

Removing `run-tests.py` file. #4180

codecov bot commented Jun 14, 2024 •

edited

Loading

prady0t commented Jun 15, 2024 •

edited

Loading