Release v24.5rc2

[kratman]

Description

Release branch for RC1

• Pre-release created
• Release tested
• Ready to merge

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[Saransh-cpp]

I think this PR can be closed. Something went wrong with the GitHub steps and we should not go directly from rc0 to rc2 in git history for the develop branch.

[kratman]

@Saransh-cpp other way around. I made the rc1 release with a mistake, yanked it, and then made rc2

[kratman]

When v24.5 was merged into develop, all of develop was merged into that branch. This one is cherry picked directly on top of the rc0 tag. The mistake in RC1 was that I created it with the v24.5 branch, which was not the same as rc0.

Once rc2 was tested, I was going to fix the v24.5 branch to make it match

[Saransh-cpp]

Yes, I went through the branches and releases. The three branches have started diverging, which is causing conflicts. We yanked the rc1 release but I think it should still be present in the git history, given that we did make a release (and it is on our GitHub as well). The additional conflicts from this branch are also an issue.

Merging the rc1 changes into develop first and then the rc2 ones would make all the conflicts/branch divergences go away.

[kratman]

@Saransh-cpp, @brosaplanella, @agriyakhetarpal I am going to sync this with develop so it can be merged. Then I will delete the branch after.

The v24.5 branch will be updated to the v24.5rc2 tag

[Saransh-cpp]

I think you'll have to rebase and resolve the conflicts.

Edit: Sorry! Just saw your comment above.

[kratman]

@Saransh-cpp I know. I was waiting to hear back about any issues with the rc before syncing this branch. I am going to sync and merge this later today

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (9afe45e) to head (fe39f99).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4259   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files          288      288           
  Lines        22086    22086           
========================================
  Hits         21966    21966           
  Misses         120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Saransh-cpp]

Thanks for working on this, @kratman!