Moving a bunch of unit tests to pytest. #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
|
This PR got a bit bigger than I expected I should have broken it down as 2 separate PR's. I can revert changes from files but since all of them are in one single commit, I'll have do it manually. Do let me know if it's difficult to review, I'll revert then. |
…into moving-to-pytest-3 Merging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4264 +/- ##
===========================================
- Coverage 99.56% 99.45% -0.11%
===========================================
Files 288 288
Lines 22086 22086
===========================================
- Hits 21989 21966 -23
- Misses 97 120 +23 ☔ View full report in Codecov by Sentry. |
tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_mpm_half_cell.py
Outdated
Show resolved
Hide resolved
tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spm.py
Outdated
Show resolved
Hide resolved
tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spme.py
Outdated
Show resolved
Hide resolved
tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_newman_tobias.py
Show resolved
Hide resolved
…on/test_mpm_half_cell.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
…on/test_spm.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
…on/test_spme.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
commented
Jul 14, 2024
tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_newman_tobias.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
agriyakhetarpal
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
This looks all great to me, thanks for updating so many files here, @prady0t! Thanks for updating the files tracker as well. I'll approve the workflow and trigger a CI run, will merge in a day or so if there are no objections.
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this pull request
Aug 12, 2024
* Moving a bunch of unit tests to pytest Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * style: pre-commit fixes * style fix Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Update tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_mpm_half_cell.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spm.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spme.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/unit/test_parameters/test_parameter_sets_class.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/unit/test_parameters/test_parameter_sets_class.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * Update tests/unit/test_plotting/test_plot.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * adding skips Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> * Update tests/unit/test_plotting/test_plot.py Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com> * adding reason for skips Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> --------- Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #4156
Total 52 small unit test files with minimal changes required are converted to pytest.