Corrects "electrode diffusivity" error catch

[BradyPlanden]

Description

This reverts an incorrect change applied in #4179. This adds to the error catch for the old parameter name "{domain} electrode diffusivity [m2.s-1]" to use the new name, likewise if the new name "{domain} particle diffusivity [m2.s-1]" is provided the error catch uses the old name.

I've confirmed it fixes the MWE in #4176, and currently works with the old parameter name within PyBOP. A quick MWE to test this fix is below:

import pybamm
# create the model
model = pybamm.lithium_ion.DFN()

# set the default model parameters
param = model.default_parameter_values

# use both parameter names
neg_old = param["Negative electrode diffusivity [m2.s-1]"] = 2.0
pos_new = param["Positive particle diffusivity [m2.s-1]"] = 2.0
assert neg_old == pos_new

Fixes #4176

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
• All tests pass: $ python run-tests.py --all (or $ nox -s tests)
• The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (668e563) to head (77e6a9c).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4267   +/-   ##
========================================
  Coverage    99.45%   99.45%           
========================================
  Files          288      288           
  Lines        22089    22092    +3     
========================================
+ Hits         21969    21972    +3     
  Misses         120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agriyakhetarpal]

This LGTM, thanks, @BradyPlanden – just one question since this was deprecated before the v24.1 release cycle and thus with the release of v24.1 (but incorrectly as far as I understand), so the plan would have been to remove it in v25.1 (three releases). Since the behaviour change is being made "not breaking" now but has existed beforehand, when should/could this be deprecated? It would help reduce the code for dependents like PyBOP where it has caused much trouble, I assume, so there's a case to be made for deprecating earlier.

[kratman]

Seems fine