-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tanks in series #4310
base: develop
Are you sure you want to change the base?
Tanks in series #4310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4310 +/- ##
===========================================
- Coverage 99.50% 99.46% -0.05%
===========================================
Files 289 290 +1
Lines 22146 22242 +96
===========================================
+ Hits 22037 22123 +86
- Misses 109 119 +10 ☔ View full report in Codecov by Sentry. |
You need to average in both x- and r-directions, you can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely on the right track! Still needs tests and documentations, we can talk about how to add those.
pybamm/models/full_battery_models/lithium_ion/tanks_in_series.py
Outdated
Show resolved
Hide resolved
pybamm/models/full_battery_models/lithium_ion/tanks_in_series.py
Outdated
Show resolved
Hide resolved
pybamm/models/full_battery_models/lithium_ion/tanks_in_series.py
Outdated
Show resolved
Hide resolved
pybamm/models/full_battery_models/lithium_ion/tanks_in_series.py
Outdated
Show resolved
Hide resolved
It seems to be working now with Chen2020 parameter set. |
…nto tanks_in_series
…nto tanks_in_series
Looking good! Have you done a comparison to other models, e.g. using this example? |
Tanks-In-Series Model
Implementation of the tanks in series model within Pybamm. Based on DOI: 10.1149/2.0342001JES.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: