-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uv
support in CI
#4353
uv
support in CI
#4353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4353 +/- ##
========================================
Coverage 99.42% 99.42%
========================================
Files 292 292
Lines 22215 22215
========================================
Hits 22087 22087
Misses 128 128 ☔ View full report in Codecov by Sentry. |
The tests pass now as the upstream bug got resolved. |
@santacodes, @agriyakhetarpal If we are being impacted by bugs in UV, maybe we should keep using pip until it is more stable |
I don't think there should be any more bugs that are relevant to our current use case. I would suggest that we be open to trying this out and reporting more bugs upstream – |
I think it is fine if people want to use UV locally, but it is still new and it is more important to keep our CI stable than to experiment with new tools. We can easily revisit UV in the future and we don't have to risk more bugs impacting our deliveries |
How about keeping it for PR builds? It's more than just a new tool at this point. The improvement is going to be substantial even without a cache because we can avoid two to three minutes of Also, I didn't get what you meant by our deliveries, since Other projects such as NumPy and SciPy as mentioned in #3825 (comment) are unlikely to use Another reason I advocate for this PR, besides the reasons posted by @Saransh-cpp in #3825 (comment) is that we didn't take as much time to implement Footnotes
|
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite nice, thanks @santacodes! Have there been any speedups in the CI with this PR?
Looking at the test actions, specifically in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks @santacodes
Description
Added support for
uv
backend innox-session
and changed to defaultuv pip
install in CI to fasten the installation times.Note: This is a work in progress and
uv
fails to installiree-compiler
from the source link specified using the--find-links
flag (logs). It is an upstream problem, and we would have to wait until it gets resolved.Reference issues - astral-sh/uv/issues/6082, y21/tl/issues/68
Fixes #3825
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: