Final pytest migration

[prady0t]

WIP

[prady0t]

Just two files left
test_idaklu_jax.py : remove parameterized dependency.
test_solution.py : problem with converting assertLogs to pytest

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (62a7ee8) to head (5345162).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4443   +/-   ##
========================================
  Coverage    99.46%   99.46%           
========================================
  Files          293      293           
  Lines        22332    22332           
========================================
  Hits         22212    22212           
  Misses         120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[agriyakhetarpal]

Unfortunately, there's no standard way to replace self.assertLogs() as far as I could find. I think the best way is to hack into PyBaMM's logger and retrieve the result you want, which is okay since we have just one test that uses this. For example,

import io
import logging
log_capture = io.StringIO()
handler = logging.StreamHandler(log_capture)
handler.setLevel(logging.ERROR)
logger = logging.getLogger('pybamm.logger')
logger.addHandler(handler)

and then, if you run the code that should produce the logger warning: pybamm.Solution(ts, bad_ys, model, {}), you can check the output using log_capture.getvalue() and check if "exceeds the maximum" string is in there. Later, you can destroy the handler using logger.removeHandler(handler) and clean it up, so that it doesn't affect any other tests. This worked for me as a quick experiment, could you try and see how it holds up in the test suite?

[agriyakhetarpal]

@prady0t, how is this going? The tests are all already passing here, and the approach I suggested should be okay in general – it works on my machine. Please let me know if you need additional help with this.

[prady0t]

Hi. I've updated the files. Lets wait for CI to run.

[agriyakhetarpal]

Thanks, @prady0t – I guess the next step to do after this PR should be to disallow the use of unittest through the Ruff rule as we discussed earlier

Edit: I notice some failing tests with the parameterisation, could you try fixing them locally?

[prady0t]

@agriyakhetarpal I've updated this PR.

[agriyakhetarpal]

Thanks for completing the migration, @prady0t!