Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing all instances of unittest #4472

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Removing all instances of unittest #4472

merged 4 commits into from
Oct 1, 2024

Conversation

prady0t
Copy link
Contributor

@prady0t prady0t commented Sep 28, 2024

WIP, will be adding ruff rule here.

@prady0t
Removing all instances of unittest
a4c3a82 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t prady0t marked this pull request as draft September 28, 2024 17:22
@prady0t prady0t mentioned this pull request Sep 28, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (b6fa67a) to head (b11754a).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4472   +/-   ##
========================================
  Coverage    99.46%   99.46%           
========================================
  Files          293      293           
  Lines        22332    22332           
========================================
  Hits         22212    22212           
  Misses         120      120

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prady0t
Adding ruff rules
1628017 
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
@prady0t
Merge branch 'implementing-pytest-rule' of https://github.com/prady0t…
b11754a 
…/PyBaMM into implementing-pytest-rule

Merge
@prady0t prady0t marked this pull request as ready for review September 29, 2024 05:09
@prady0t
Copy link
Contributor Author

prady0t commented Sep 29, 2024

I've added two rules, PT027 and PT009. These won't detect the usage of unittest, but is enough to prevent someone from writing tests in future as it prevents using unittest style assertions.

Saransh-cpp
Saransh-cpp requested changes Sep 29, 2024
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, thanks, @prady0t!

pyproject.toml
Comment on lines +199 to +200
"PT027", # remove unittest style assertion
"PT009", # Use pytest.raises instead of unittest-style
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead try turning on the "PT" rule commented above and see what happens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of style failures. Should I try fixing those and keep the PT rule?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are too many, then a separate PR for this would be better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate PR sounds good then. Could you create one after this, @prady0t?

@kratman kratman merged commit 78c2410 into pybamm-team:develop Oct 1, 2024
26 checks passed
pkalbhor pushed a commit to pkalbhor/PyBaMM that referenced this pull request Nov 15, 2024
@prady0t @pre-commit-ci
Removing all instances of unittest (pybamm-team#4472)
a6e0e2e 
* Removing all instances of unittest

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

* style: pre-commit fixes

* Adding ruff rules

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>

---------

Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

@kratman kratman kratman approved these changes

@martinjrobins martinjrobins Awaiting requested review from martinjrobins martinjrobins is a code owner

@agriyakhetarpal agriyakhetarpal Awaiting requested review from agriyakhetarpal agriyakhetarpal is a code owner

@arjxn-py arjxn-py Awaiting requested review from arjxn-py arjxn-py is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prady0t @kratman @Saransh-cpp @agriyakhetarpal