Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jax links #4504

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Fix Jax links #4504

merged 4 commits into from
Oct 11, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Oct 11, 2024

Description

It looks like the https://github.com/google/jax moved to https://github.com/jax-ml/jax

This should fix the link checking.

Type of change

Fix for link checkers

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman enabled auto-merge (squash) October 11, 2024 16:15
@kratman
Copy link
Contributor Author

kratman commented Oct 11, 2024

Note: Sometimes the link checker fails, other times it passes. I suspect this is related to the re-direct from the old repo name

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kratman

@kratman kratman merged commit 3bf3ea8 into pybamm-team:develop Oct 11, 2024
24 checks passed
@kratman kratman deleted the feat/lycheeJax branch October 11, 2024 16:44
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (7ea74f3) to head (180262f).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4504   +/-   ##
========================================
  Coverage    99.42%   99.42%           
========================================
  Files          299      299           
  Lines        22691    22691           
========================================
  Hits         22560    22560           
  Misses         131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants