Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VCS versioning and mypy #7

Merged
merged 2 commits into from
Aug 15, 2023
Merged

feat: VCS versioning and mypy #7

merged 2 commits into from
Aug 15, 2023

Conversation

Saransh-cpp
Copy link
Member

VCS versioning by default for the project and the template.

mypy for the project (I think adding an option for the template would make this PR huge, but I'll add it through another PR 🙂)

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow nice there are a lot of changes. Making mypy optional in the template would be great, especially because we were not using it for the project (should we do that?). Also, could you clarify if there will be changes on how we update versions while making a release with the addition of hatch-vcs—is there anything to keep in mind after one updates the version in __init__.py, because I read it uses timestamps from version control systems? That way I will include relevant resources when I prepare the documentation for using the template. Thanks for doing this, @Saransh-cpp!

@Saransh-cpp
Copy link
Member Author

especially because we were not using it for the project (should we do that?)

This PR adds mypy for the project!

Also, could you clarify if there will be changes on how we update versions while making a release with the addition of hatch-vcs—is there anything to keep in mind after one updates the version in init.py

Create a new release on GitHub and done 🙂

hatch-vcs will automatically fetch that git tag and bump the version. Or, if you are working locally, create a new git tag and that is your new version!

@agriyakhetarpal
Copy link
Member

That sounds great, will simplify a lot of things. The changes look good to me, feel free to merge whenever

@Saransh-cpp
Copy link
Member Author

Thanks for the review! Merging.

@Saransh-cpp Saransh-cpp merged commit d68c0df into main Aug 15, 2023
@Saransh-cpp Saransh-cpp deleted the hatch-vcs branch August 15, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants