Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compare_methods.py #17

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Update compare_methods.py #17

merged 1 commit into from
Jul 21, 2024

Conversation

noelhallemans
Copy link
Contributor

Avoiding spectral leakage in time domain simulation by simulating an integer number of periods.

Ensuring linearity of the time domain simulation by keeping the amplitude low.

Set the solver's absolute tolerance lower to simulate small currents.

The time and frequency domain impedance simulations overlap nicely now! (Only the bicgstab method behaves poorly)

Avoiding spectral leakage in time domain simulation by simulating an integer number of periods.

Ensuring linearity of the time domain simulation by keeping the amplitude low.

Set the solver's absolute tolerance lower to simulate small currents.

The time and frequency domain impedance simulations overlap nicely now! (Only the bicgstab method behaves poorly)
Copy link
Collaborator

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rtimms rtimms merged commit 534ceb2 into pybamm-team:main Jul 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants