Check if valgrind-detected after-freeing access of PyMethodDef causes…

… macOS Python 3.9 segfaults
pybind · Oct 11, 2020 · 61e40f6 · 61e40f6
1 parent 7d7309b
commit 61e40f6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -70,12 +70,6 @@ jobs:
             python: pypy3
             arch: x64
 
-            # TODO: renable
-            # Currently segfaults on macOS Python 3.9
-          - runs-on: macos-latest
-            python: 3.9
-            arch: x64
-
     name: "🐍 ${{ matrix.python }} • ${{ matrix.runs-on }} • ${{ matrix.arch }} ${{ matrix.args }}"
     runs-on: ${{ matrix.runs-on }}
 

diff --git a/include/pybind11/pybind11.h b/include/pybind11/pybind11.h
@@ -466,7 +466,7 @@ class cpp_function : public function {
             }
             if (rec->def) {
                 std::free(const_cast<char *>(rec->def->ml_doc));
-                delete rec->def;
+                //delete rec->def;
             }
             delete rec;
             rec = next;