-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: contrib/issue templates #2377
Conversation
Is it urgent to move Apart from that, I'm OK with this, but this isn't too urgent and I can imagine @wjakob wants to have a say/some input in this? So I'd suggest waiting before merging this until we can get some feedback? |
It was @wjakob's suggestion that we clean up the main folder a bit, though have no idea if likes No rush, agreed. |
(Just assigning to @wjakob, so he can have a clear overview, in a few weeks) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Henry, this looks great to me, just a few small suggestions.
How much trouble is it to move CONTRIBUTING.md in a separate PR: a pure move no changes?
That way it's easiest to see what changed.
I've moved it back - we can move it later. |
Looks all good to me, and moving the github-related markdown files to a |
I'll do the move in a separate PR. |
This sets up some GitHub specifics to make the main pages a little cleaner, add nice issue templates and a prominent link to the gitter, and adds information requested by @rwgk about setting up development environments and building with CMake.
A second PR can be made to move
CONTRIBUTING.md
to.github/CONTRIBUTING.md
, to save a little space on the main page. We can add a nice link to it fromREADME.md
.