-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(setup): support overriding CMake args #3577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do this for Habitat-Sim as well. Surprised this issue wasn't already brought up and fixed.
(On hold until I work out the actual problem with conda-forge - I think they are going 2017 -> 2019 and the transition is broken). If the original code works after this is sorted, I'd be up in the air about putting this in - we might want the ability to override the CMake command, so I think I'd still be in favor of it. |
Building from true source is very rare - honestly, I probably could move conda-forge over to using the SDist, and not bother with the build from git source. However, I think the reason I don't do that is then I'd have two source files and it would be harder to automate the maintenance. |
This sort of patch is not needed to support conda-forge (see conda-forge/pybind11-feedstock#75). It might still be a good idea, though? |
for more information, see https://pre-commit.ci
Description
Supports setting CMAKE_ARGS to control the CMake file generation. Needed for conda-forge, which does not find the compiler otherwise.
See conda-forge/pybind11-feedstock#74.
Suggested changelog entry: