Fix module extension detection for python 3.10 #3663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Jan 29, 2022
tools/pybind11NewTools.cmake
Outdated
| @@ -110,7 +110,7 @@ if(NOT DEFINED PYTHON_MODULE_EXTENSION) | |||
| execute_process( | |||
| COMMAND | |||
| "${${_Python}_EXECUTABLE}" "-c" | |||
| "from distutils import sysconfig as s;print(s.get_config_var('EXT_SUFFIX') or s.get_config_var('SO'))" | |||
| "import sys; s = __import__('distutils.sysconfig').sysconfig if sys.version_info < (3, 10) else __import__('sysconfig'); print(s.get_config_var('EXT_SUFFIX') or s.get_config_var('SO'))" | |||
There was a problem hiding this comment.
Suggested change
| "import sys; s = __import__('distutils.sysconfig').sysconfig if sys.version_info < (3, 10) else __import__('sysconfig'); print(s.get_config_var('EXT_SUFFIX') or s.get_config_var('SO'))" | |
| "import sys, importlib; s = importlib.import_module('distutils.sysconfig' if sys.version_info < (3, 10) else 'sysconfig'); print(s.get_config_var('EXT_SUFFIX') or s.get_config_var('SO'))" |
https://docs.python.org/3/library/importlib.html#importlib.import_module
henryiii
approved these changes
Jan 29, 2022
|
LGTM (but it's out of my wheelhouse). |
Skylion007
approved these changes
Jan 31, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was having issues with python 3.10, looks like
distutils.sysconfighas been merged intosysconfig(https://docs.python.org/3/distutils/apiref.html#module-distutils.sysconfig) so this adds a condition to import sysconfig on python >= 3.10.Probably not the most "pythonic" code but I kept it as a 1 liner.
Suggested changelog entry: