Revert "Work-Around: NVCC 11.4.0 - 11.8.0" #4230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6cb2147.
|
The commit mentioned in the previous comment had a flaw due to a misunderstanding, fixed in 7557684. Retesting. |
|
It is pretty much certain now that the forward fix in #4228 is working. The CI for that PR passes, I just need to reduce my new test before sending it for review. The forward fix also works for the smart_holder branch (#4227), although something else is still failing for CUDA 11.7 (type_caster_odr_guard), but that is not critical, I just need to add some kind of suppression for this non-cooperating compiler (the only thing I truly care about is that the type_caster_odr_guard works Google-internally). |
|
Okay, will go with that one, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4220