Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix functional.h bug + introduce test to verify that it is fixed #4254

Merged
merged 32 commits into from
Nov 2, 2022
Merged

Fix functional.h bug + introduce test to verify that it is fixed #4254

merged 32 commits into from
Nov 2, 2022

Commits on Nov 1, 2022

  1. Illustrate bug in functional.h

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    56cd516 View commit details
    Browse the repository at this point in the history

  2. style: pre-commit fixes

    @pre-commit-ci @EthanSteinberg
    pre-commit-ci[bot] authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ba640fd View commit details
    Browse the repository at this point in the history

  3. Make functional casting more robust / add workaround

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    e85ed9b View commit details
    Browse the repository at this point in the history

  4. Make function_record* casting even more robust

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    7f3ff9b View commit details
    Browse the repository at this point in the history

  5. See if this fixes PyPy issue

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    fbdf4aa View commit details
    Browse the repository at this point in the history

  6. It still fails on PyPy sadly

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    9deba24 View commit details
    Browse the repository at this point in the history

  7. Do not make new CTOR just yet

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    4c6c768 View commit details
    Browse the repository at this point in the history

  8. Fix test

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    c36f3a8 View commit details
    Browse the repository at this point in the history

  9. Add name to ensure correctness

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    1aaf98b View commit details
    Browse the repository at this point in the history

  10. style: pre-commit fixes

    @pre-commit-ci @EthanSteinberg
    pre-commit-ci[bot] authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    871273c View commit details
    Browse the repository at this point in the history

  11. Clean up tests + remove ifdef guards

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    4962a5d View commit details
    Browse the repository at this point in the history

  12. Add comments

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3a8f0f3 View commit details
    Browse the repository at this point in the history

  13. Improve comments, error handling, and safety

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8dce8b3 View commit details
    Browse the repository at this point in the history

  14. Fix compile error

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    eca0cbf View commit details
    Browse the repository at this point in the history

  15. Fix magic logic

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    a0d5be3 View commit details
    Browse the repository at this point in the history

  16. Extract helper function

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    184534e View commit details
    Browse the repository at this point in the history

  17. Fix func signature

    @Skylion007 @EthanSteinberg
    Skylion007 authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f92cb03 View commit details
    Browse the repository at this point in the history

  18. move to local internals

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    17b1f91 View commit details
    Browse the repository at this point in the history

  19. style: pre-commit fixes

    @pre-commit-ci @EthanSteinberg
    pre-commit-ci[bot] authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    3e04c07 View commit details
    Browse the repository at this point in the history

  20. Switch to simpler design

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    13b5fea View commit details
    Browse the repository at this point in the history

  21. style: pre-commit fixes

    @pre-commit-ci @EthanSteinberg
    pre-commit-ci[bot] authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    71f97d1 View commit details
    Browse the repository at this point in the history

  22. Move to function_record

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    5c07f91 View commit details
    Browse the repository at this point in the history

  23. style: pre-commit fixes

    @pre-commit-ci @EthanSteinberg
    pre-commit-ci[bot] authored and EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    aae5968 View commit details
    Browse the repository at this point in the history

  24. Switch to internals, update tests and docs

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8edaae7 View commit details
    Browse the repository at this point in the history

  25. Fix lint

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8f8a873 View commit details
    Browse the repository at this point in the history

  26. Oops, forgot to resolve last comment

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    2d054d3 View commit details
    Browse the repository at this point in the history

  27. Fix typo

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8e4cece View commit details
    Browse the repository at this point in the history

  28. Update in response to comments

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    aa89200 View commit details
    Browse the repository at this point in the history

  29. Implement suggestion to improve test

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    f184c54 View commit details
    Browse the repository at this point in the history

  30. Update comment

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    14b7e33 View commit details
    Browse the repository at this point in the history

  31. Simple fixes

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    d54fa89 View commit details
    Browse the repository at this point in the history

  32. Merge remote-tracking branch 'upstream/master' into functional_bug

    @EthanSteinberg
    EthanSteinberg committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    13cb394 View commit details
    Browse the repository at this point in the history